Skip to content

To enhance the performance and support wildcards #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

To enhance the performance and support wildcards #175

wants to merge 1 commit into from

Conversation

liyuj
Copy link

@liyuj liyuj commented Dec 5, 2016

1 the current version does not support wildcards, PathMatchingResourcePatternResolver support wildcards;
2 when the number of files in the package is very much, the performance of ResolverUtil is very poor;
3 in the test with our environment, a total of about 20000 files, ResolverUtil takes 180 seconds, while PathMatchingResourcePatternResolver only used 5 seconds.

1 the current version does not support wildcards, PathMatchingResourcePatternResolver support wildcards;
2 when the number of files in the package is very much, the performance of ResolverUtil is very poor;
3 in the test with our environment, a total of about 20000 files, ResolverUtil takes 180 seconds, while PathMatchingResourcePatternResolver only used 5 seconds.
@kazuki43zoo
Copy link
Member

Hi @liyuj , Sorry for very late reply.
I am interested in this topic because this PR help to resolve mybatis/spring-boot-starter#314. If you have a time for fixing this,I would like to request the following tasks.

  • Support the same feature for TypeHandler
  • Add tests
  • Resolve conflict

Thanks again for contributing.

@kazuki43zoo
Copy link
Member

Hi @liyuj ,

I try to fix this via gh-359.
WDYT?
If you are OK, I will merge into master branch and release 2.0.1 as soon as possible.

kazuki43zoo added a commit to kazuki43zoo/spring that referenced this pull request Apr 4, 2019
@liyuj
Copy link
Author

liyuj commented Apr 4, 2019 via email

@kazuki43zoo
Copy link
Member

Hi @liyuj,

This PR is closed because I will resolve via gh-359. then .
Thank you for your contributing!!

@kazuki43zoo
Copy link
Member

I've fixed via gh-359.

pulllock pushed a commit to pulllock/mybatis-spring that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants